Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual improvements #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Visual improvements #8

wants to merge 5 commits into from

Conversation

HasanMothaffar
Copy link
Collaborator

Overview

This PR adds the following visual improvements:

  1. Add a trail that follows satellites in orbit.
  2. Add a collision effect (particles explosion)

Note

Please review the case in which the trail reaches that MAXIMUM_TRAIL_POINTS limit.

Steps to reproduce:

  1. Add a new satellite with a high velocity.
  2. Speed up the simulation.
  3. Wait for a couple of seconds then observe the movement of the trail.

If it seems ugly I can stop the track from being drawn altogether, but this is the best I could come up with.

@HasanMothaffar HasanMothaffar self-assigned this Jun 26, 2022
@HasanMothaffar HasanMothaffar added the enhancement New feature or request label Jun 26, 2022
@Rami-Sabbagh
Copy link
Owner

It seems this branch is somehow already deployed?

@HasanMothaffar
Copy link
Collaborator Author

It seems this branch is somehow already deployed?

I guess so, but I have no idea why. The CI pipeline is configured to deploy to GitHub pages only on creating a new tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HasanMothaffar HasanMothaffar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HasanMothaffar @Rami-Sabbagh