Does it work with Navigation Controller?

[AnnieNinaJoyceV]

I tried adding Navigation Controller to Demo project and the detail view transition doesn't seem to be happening.

And thanks for this wonderful work :)

[av0c0der]

@AnnieNinaJoyceV you're welcome!

This control wasn't designed to use within UINavigationController. Maybe there is a reason make it available to embed ElongationViewController to navigation stack, but I'm not sure about ElongationDetailViewController (the second one).

[AnnieNinaJoyceV]

@jauzee I got it working by Tweaking func root(from context: UIViewControllerContextTransitioning) -> ElongationViewController
This works for me with UINavigationController - Navigation Bar hidden. I just wanted to know confirm whether there is some other approach. Thanks for your response.

fileprivate func root(from context: UIViewControllerContextTransitioning) -> ElongationViewController { guard let c = context.viewController(forKey: rootKey) else { return context.viewController(forKey: rootKey) as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil) } if (c.isKind(of: UINavigationController.self)) { guard let nv = c as? UINavigationController else { return context.viewController(forKey: rootKey) as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil) } let v = nv.topViewController return v as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil) } return context.viewController(forKey: rootKey) as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil) }

[av0c0der]

@AnnieNinaJoyceV, sorry for the delay. You did it in very complex way. We'll look on that.

[AnnieNinaJoyceV]

@jauzee No problem, it works for me right now. I will wait for your solution to this.

[av0c0der]

@AnnieNinaJoyceV fixed this issue in 1.0.4.

Actually we'll just check if there is an UINavigationContoller and if so we'll iterate over viewControllers looking for ElongationViewController.

[sasquatchgit]

@AnnieNinaJoyceV code but formatted:

fileprivate func root(from context: UIViewControllerContextTransitioning) -> ElongationViewController {
        guard let c = context.viewController(forKey: rootKey) else {
            return context.viewController(forKey: rootKey) as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil)
            
        }
        if (c.isKind(of: UINavigationController.self)) {
            guard let nv = c as? UINavigationController else {
                return context.viewController(forKey: rootKey) as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil)
            }
            let v = nv.topViewController
            return v as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil)
        }
        return context.viewController(forKey: rootKey) as? ElongationViewController ?? ElongationViewController(nibName: nil, bundle: nil)
        
    }

[kunwar231]

how to show navigation bar on ElongationDetailViewController?