Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add round to the calculation of the currentIndex in ExpandingViewController #12

Closed
grundid opened this issue Jun 6, 2016 · 3 comments
Closed

Comments

@grundid
Copy link

grundid commented Jun 6, 2016

Thx for this cool library. I'm trying to add to my project.

Right now I have an issue with the currentIndex. When I peek at the card, the collectionView.contentOffset.x is 221.5, but when I go to the ExpandingTableViewController and then return, the collectionView.contentOffset.x changes to 221.0. This leads to currentIndex pointing at the previous card.

I guess it could be easily fixed by rounding the result.

@0ber
Copy link
Contributor

0ber commented Jun 6, 2016

I can't repeat issues in demo example. What device are you using ?

@grundid
Copy link
Author

grundid commented Jun 6, 2016

I'm testing it on an iPhone 6s. Your demo runs fine.
I guess I have some minor misalignment in my UI.

Nonetheless I thing that rounding the currentIndex value would be more appropriate than truncating the value.

@0ber 0ber closed this as completed in 656aa95 Jun 6, 2016
@grundid
Copy link
Author

grundid commented Jun 6, 2016

Thanks! Version 0.0.6 works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants