Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote display #544

Closed
pyrmont opened this issue Feb 12, 2019 · 6 comments
Closed

Footnote display #544

pyrmont opened this issue Feb 12, 2019 · 6 comments
Milestone

Comments

@pyrmont
Copy link

pyrmont commented Feb 12, 2019

As of 5.0d15 (1517), NNW does not provide any built-in support for the display of footnotes. Links to footnotes jump the user out to the browser.

I think it would improve the user experience if NNW either displayed the footnote with some kind of popover (see an example below from Feedbin's website) or rewrote the URL so that clicking on the footnote link jumped to the end of the text within NNW.

Footnote Example from Feedbin

@pyrmont pyrmont changed the title Footnote Display Footnote display Mar 1, 2019
@brentsimmons brentsimmons added this to the 5.x milestone Jun 8, 2019
@benubois
Copy link
Member

Feedbin uses bigfoot.js for this. It's easy to implement and should work fine in a WKWebView. NetNewsWire would need to include jQuery and the bigfoot JavaScript and CSS files in the article template.

Then it could run $.bigfoot(); whenever the article changes.

@pyrmont pyrmont closed this as completed Sep 12, 2019
@pyrmont pyrmont reopened this Sep 12, 2019
@pyrmont
Copy link
Author

pyrmont commented Sep 13, 2019

An alternative to bigfoot.js if you don't want to bring in JQuery is Barefoot. Its biggest downside is that it doesn't appear to be maintained any more. My PR fixing a bug remains outstanding.

(Apologies for the double comment; I tapped 'Close and comment' by mistake while writing the previous comment.)

@trentshell
Copy link

Littlefoot.js is another alternative that seems to be actively maintained.

@vincode-io
Copy link
Member

@brehaut I've merged your pull request, but am having trouble getting it work with the example above. I went to Feedbin and searched for the article, then starred it. I was then able to go to the starred article. When I click on the footnote link, I get taken out of the application and go into a browser that takes me to the web page for the article.

Did we lose something while doing the merge?

@vincode-io vincode-io modified the milestones: 5.x, 5.1 Alpha Sep 25, 2019
@brehaut
Copy link
Contributor

brehaut commented Sep 25, 2019

@vincode-io Looks like the merge was fine.

Apparently I didn't have Daring Fireball in my corpus of test cases. It looks like the markup there is slightly different to the footnote markup to what the script is looking for. I'll amend this, and see if there are any other common formats I’ve missed, and make a new pull request tonight.

@vincode-io
Copy link
Member

This works and it looks awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants