Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled error that crashes and restarts the entire process #13

Open
kevinejohn opened this issue Nov 13, 2020 · 1 comment
Open

Unhandled error that crashes and restarts the entire process #13

kevinejohn opened this issue Nov 13, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@kevinejohn
Copy link

I'm running and using a hyperswarm-web proxy and without any special client dat-sdk configuration (Just setting the swarmOpts: bootstrap url) I sometimes get this error which kills and restarts the process. Not sure if it's related to this: #12

Nov 13 21:49:28 server-1 systemd[1]: Started Hyperswarm proxy server which webpages can connect to..
Nov 13 21:49:29 server-1 hyperswarm-web[21158]: Listening on ws://localhost:4977
Nov 13 21:49:29 server-1 hyperswarm-web[21158]: -> Proxy available on ws://localhost:4977/proxy
Nov 13 21:49:29 server-1 hyperswarm-web[21158]: -> Signal available on ws://localhost:4977/signal
Nov 13 21:49:31 server-1 hyperswarm-web[21158]: events.js:200
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:       throw er; // Unhandled 'error' event
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:       ^
Nov 13 21:49:31 server-1 hyperswarm-web[21158]: Error: Groups are not supported
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at exports.skip (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/protocol-buffers-encodings/index.js:29:13)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Object.decode (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/hyperswarm-proxy/messages.js:147:18)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Client._write (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/hyperswarm-proxy/index.js:109:34)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at doWrite (_stream_writable.js:435:12)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at writeOrBuffer (_stream_writable.js:419:5)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Client.Writable.write (_stream_writable.js:309:11)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Decoder.ondata (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/readable-stream/lib/_stream_readable.js:681:20)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Decoder.emit (events.js:223:5)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at addChunk (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/readable-stream/lib/_stream_readable.js:298:12)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at readableAddChunk (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/readable-stream/lib/_stream_readable.js:280:11)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]: Emitted 'error' event on HyperswarmServer instance at:
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Client.<anonymous> (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/hyperswarm-proxy/server.js:52:14)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Object.onceWrapper (events.js:313:26)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Client.emit (events.js:228:7)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at errorOrDestroy (internal/streams/destroy.js:108:12)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at onwriteError (_stream_writable.js:450:5)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at onwrite (_stream_writable.js:477:5)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Client._write (/home/user1/.nvm/versions/node/v12.14.1/lib/node_modules/hyperswarm-web/node_modules/hyperswarm-proxy/index.js:120:7)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at doWrite (_stream_writable.js:435:12)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at writeOrBuffer (_stream_writable.js:419:5)
Nov 13 21:49:31 server-1 hyperswarm-web[21158]:     at Client.Writable.write (_stream_writable.js:309:11)
@RangerMauve
Copy link
Owner

Interesting, I'm not sure what's causing the error to be thrown, but I think it'd be worthwhile to catch errors from connections and log them to to console instead of letting them crash the process.

Would you be down to submit a PR to hyerswarm-proxy to address this?

@RangerMauve RangerMauve added the bug Something isn't working label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants