Use a more conservative estimate of overhead #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous estimate based on the mumble client settings frequently caused skipping when trying to transmit audio. In order to prevent this, this commit makes the overhead estimate higher so the client will use a lower bitrate.
|
Thanks! If this fixed the issue for you, that's good enough for me in this case. |
|
Published the change in version 0.3.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous estimate based on the mumble client settings frequently caused skipping when trying to transmit audio. In order to prevent this, this commit makes the overhead estimate higher so the client will use a lower bitrate.
From my testing, a nodejs client with the bitrate set to 128,000 reached up to 165,400. To get to the overhead estimate I used here, I rounded 165,400 up to 170,000 to be safe, and subtracted 128,000.
This should fix #59