Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF crash with Skyblocker #101

Closed
Julienraptor01 opened this issue Aug 9, 2023 · 2 comments
Closed

IF crash with Skyblocker #101

Julienraptor01 opened this issue Aug 9, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Julienraptor01
Copy link

Original issue : SkyblockerMod/Skyblocker#215

Steps and Explanation by @AzureAaron

Yep I can reproduce it reliably with skyblocker :

Steps:

  1. Be on your private island & have Fairy Souls Helper disabled
  2. Enter the hub
  3. Enable the fairy souls helper
  4. IF instantly crashes the game

Explanation:
the "optimized" buffer stuff from ImmediatlyFast can cause crashes when attempting to render things.

I encountered the crash java.lang.NullPointerException: Cannot invoke "java.nio.ByteBuffer.rewind()" because "this.field_1555" is null from something in my own mod, but based on #215 (and from my own investigation) stuff in Skyblocker can trigger the crash as well.

It occurs because IF sets the buffer inside of the BufferBuilder to null sometimes (which can never happen in vanilla), so when the buffer is attempted to be rewound it triggers the NullPointerException.

Log: latest.log

@RaphiMC
Copy link
Owner

RaphiMC commented Aug 10, 2023

This build should fix it. Please confirm as I didn't test it: https://upload.raphimc.net/file/gqDmMBBUVZIxWMxE/1hbBFVZwS4LqFi6u/ImmediatelyFast-1.1.27-SNAPSHOT%2B1.20.1.jar

@Julienraptor01
Copy link
Author

image
version does indeed fix

@RaphiMC RaphiMC closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants