time & weather: fix inconsistency #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- command "ctime" replaced with "settime" - edited strings to match with weather module
- fix broken set country hint message - replace errors with "Invalid country." (won't show details if it's weather provider server side problem) - make every string monospace
|
Seems fine for me, lint this and I'll merge |
|
Lint ftw |
RealAkito
reviewed
Aug 26, 2019
| @@ -41,16 +41,15 @@ | |||
| return | |||
|
|
|||
| if len(OWM_API) < 1: | |||
| await weather.edit("Get an API key from " | |||
| "https://openweathermap.org/ first.") | |||
| await weather.edit("`Get an API key from` https://openweathermap.org/ `first.`") | |||
There was a problem hiding this comment.
No need to even edit this line...
RealAkito
reviewed
Aug 26, 2019
| @@ -77,7 +76,7 @@ | |||
| result = json.loads(request.text) | |||
|
|
|||
| if request.status_code != 200: | |||
| await weather.edit(f"{result['message']}") | |||
| await weather.edit(f"`Invalid country.`") | |||
There was a problem hiding this comment.
We have it there to tell what msg the page give out alongside 200 error.
RealAkito
reviewed
Aug 26, 2019
| @@ -139,7 +138,7 @@ def sun(unix): | |||
| return | |||
|
|
|||
| if len(OWM_API) < 1: | |||
| await city.edit("Get an API key from https://openweathermap.org/ first.") | |||
| await city.edit("`Get an API key from` https://openweathermap.org/ `first.`") | |||
RealAkito
reviewed
Aug 26, 2019
| @@ -175,7 +174,7 @@ def sun(unix): | |||
| result = json.loads(request.text) | |||
|
|
|||
| if request.status_code != 200: | |||
| await city.edit(f"{result['message']}") | |||
| await city.edit(f"`Invalid country.`") | |||
There was a problem hiding this comment.
We have it there to tell what msg the page give out alongside 200 error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.