Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord.Guild converter and GuildNotFound error #6365

Merged
merged 3 commits into from Feb 7, 2021
Merged

Add discord.Guild converter and GuildNotFound error #6365

merged 3 commits into from Feb 7, 2021

Conversation

AbstractUmbra
Copy link
Contributor

@AbstractUmbra AbstractUmbra commented Jan 30, 2021

Summary

This adds a discord.Guild converter as well as the resulting error if a match is not found.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically I'm against such a converter but I guess if the shortcomings are documented it's okay, even though I think the use cases for it aren't that big.

discord/ext/commands/converter.py Show resolved Hide resolved
discord/ext/commands/converter.py Outdated Show resolved Hide resolved
discord/ext/commands/converter.py Outdated Show resolved Hide resolved
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the documentation changes required in api.rst

Mainly, adding the class to the list of converters and adding the exception to the exception hierarchy and the list of exceptions.

discord/ext/commands/converter.py Outdated Show resolved Hide resolved
@Rapptz Rapptz merged commit 68eb844 into Rapptz:master Feb 7, 2021
@Rapptz Rapptz mentioned this pull request Feb 18, 2021
@AbstractUmbra AbstractUmbra deleted the feature/guild-converter branch May 14, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants