Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store finished views/modals #9235

Merged
merged 2 commits into from Feb 14, 2023
Merged

Conversation

z03h
Copy link
Contributor

@z03h z03h commented Feb 13, 2023

Summary

Finished views are stored and never removed since they would not properly time out/stop a second time.
Consistent with other methods like edit that check if the view is finished before storing.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@z03h z03h changed the title Don't store finished views Don't store finished views/modals Feb 13, 2023
@Rapptz Rapptz merged commit e6ef431 into Rapptz:master Feb 14, 2023
@z03h z03h deleted the patch-view-send branch February 27, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants