Add and document Guild.get_emoji
#9296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puncher1
reviewed
Mar 11, 2023
Comment on lines
+756
to
+758
| if emoji and emoji.guild == self: | ||
| return emoji | ||
| return None |
There was a problem hiding this comment.
Check with if x is not None rather than with if x if you want to check if emoji is not None.
Also return emoji at the end for better readability.
Suggested change
| if emoji and emoji.guild == self: | |
| return emoji | |
| return None | |
| if emoji is not None and emoji.guild != self: | |
| return None | |
| return emoji |
There was a problem hiding this comment.
I partially agree with this but I think the current code is also fine.
Rapptz
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Guild.get_emojimethod for getting emojis from a Guild by id.Checklist