Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some async tests are not properly run #4664

Closed
erohmensing opened this issue Oct 23, 2019 · 1 comment · Fixed by #5080
Closed

Some async tests are not properly run #4664

erohmensing opened this issue Oct 23, 2019 · 1 comment · Fixed by #5080
Assignees
@alwx
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@erohmensing
Copy link
Contributor

erohmensing commented Oct 23, 2019 •
edited

5 asynchronous test methods are currently never awaited, so the tests pass pytest regardless of if the method itself should actually pass. Example: https://travis-ci.com/RasaHQ/rasa/jobs/248702574#L4028

In the case of slack, this might have been introduced during the change from httpretty to responses.
@erohmensing erohmensing added the type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. label Oct 23, 2019
@wochinge wochinge added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Oct 24, 2019
@tmbo
Copy link
Member

tmbo commented Jan 14, 2020

mhm that is odd, usually this should be done through the https://github.com/yunstanford/pytest-sanic#quick-start plugin

@alwx alwx mentioned this issue Jan 16, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alwx alwx

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make asynchronous Slack tests run properly RasaHQ/rasa
4 participants
@alwx @tmbo @wochinge @erohmensing