New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploration of new docs build system #6043
Conversation
Trying to view it, getting an error that |
@melindaloubser1 should be fixed after you pull - for some reason |
Same. Cannot find any of Rasa pages. |
@melindaloubser1 just try to open any of the pages manually. For example: http://localhost:3000/docs/changelog |
ohh thanks! |
fixed it in a push should be good now 👍 |
thanks for trying this out |
Love the pinned TOC on the right! |
this looks very exciting and promising! |
my best guess right now is that in the beginning we'll probably not use multi-version and keep a single docs version. we can try to aim more for an approach that integrates changes made into the documentation, e.g. here is an example how python does it https://docs.python.org/3.8/library/functions.html#print:
|
I've updated the newdocs with a new export, it looks pretty good now. All the things you see in the docs are automatically generated - so we can run this once we are ready even if the rst docs change in the meantime. |
added some more details to the PR description, explaining how the automatic translation from RST to markdown (MDX) works. |
looks awesome! |
looks amazing 🤗 just ran it locally and worked like a charm! |
Keeping this one open until @erohmensing reports more issues with the auto conversion. We'll try to fix most of them in this PR. |
Interactive code cells
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
awesome, very hyped about this 🚀 the page looks good, let's make sure to also include a slide in the squad sync tomorrow to make sure everyone is aware of the most important parts (e.g. docs are in md now) 👍 |
yes will do as soon as you share the slides ✅ |
Proposed changes:
Exploration of new docs build system
related to https://github.com/RasaHQ/growth/issues/1436
not all pages have been added to the new system. all of them are converted, if you are missing a page you'd like to take a look at you need to add it to
newdocs/sidebars.js
To view the page, navigate into
newdocs
, runyarn
to install dependencies and thenyarn start
. A browser page with the docs should pop up.The converter and necessary changes to fix some of the markdown issues can be found here RasaHQ/sphinx-markdown-builder#1 - should be extended and adapted to fix more issues.
How to build the MDX docs based on RST
All of the new docs pages have been created automatically. If there are any changes in the RST docs (e.g. by new features or changes merged into master), the MDX docs can be regenerated:
https://github.com/RasaHQ/sphinx-markdown-builder/pull/1
usinggit clone git://github.com/RasaHQ/sphinx-markdown-builder.git
,git checkout convert-docs
andpip install -e .
(this should be in your rasa poetry env, e.g. try runningpoetry shell
before the pip install)cd docs
and runmake markdown
This will tell sphinx to build the docs and output markdown (instead of the usual HTML). The converter is pretty flexible and if we notice any issues, we can further customize the
sphinx-markdown-builder
based on the above PR.While converting, sphinx will create somewhat of an AST and then walk through these nodes. for each node in the doc there is a hook that decides how to convert that node into markdown.
Remaining work before this can be merged is tracked in #6165
TODO
newdocs
todocs
. rename existing occurrences, e.g. https://github.com/RasaHQ/rasa/pull/6043/files#diff-793229551c14ebd7f4c0f9236d054ee0R40 0777558 and 4b18077scripts/push_docs_to_branch.sh
script 4b18077/docs/
links everywhere f758bafmake docs
(failing because of redoc)Fixes #6170