Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rasa validator shows empty error message when text: null for a response #7908

Closed
1 task
desmarchris opened this issue Feb 8, 2021 · 2 comments · Fixed by #8618
Closed
1 task

Rasa validator shows empty error message when text: null for a response #7908

desmarchris opened this issue Feb 8, 2021 · 2 comments · Fixed by #8618
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@desmarchris
Copy link
Contributor

desmarchris commented Feb 8, 2021

Rasa Version     : 2.2.2
Rasa SDK Version : 2.2.0
Rasa X Version   : None
Python Version   : 3.8.6
Operating System : macOS-10.16-x86_64-i386-64bit

Issue:
Originally reported in our forum, training/validating threw an error but didn't show anything in the file to fix. After looking at the file, one of the responses had text: null. Changing this to a random string fixed the problem. We should look into why this error wasn't showing up in the traceback

Error (including full traceback):

(e2e) chris@ChristophersMBP e2e % rasa data validate -d original-domain.yml
The configuration for pipeline was chosen automatically. It was written into the config file at 'config.yml'.
YamlValidationException: Failed to validate '/Users/chris/rasa/e2e/original-domain.yml'. Please make sure the file is correct and all mandatory parameters are specified. Here are the errors found during validation

Command or request that led to error:

rasa train
rasa validate

Content of domain file (domain.yml) (if relevant):
File is here

Definition of Done

  • YamlValidationException should show what made the schema validation fail
@desmarchris desmarchris added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Feb 8, 2021
@TyDunn TyDunn added the area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) label Apr 16, 2021
@wochinge wochinge added the effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Apr 23, 2021
@desmarchris
Copy link
Contributor Author

desmarchris commented Apr 28, 2021

there have been a few more cases in this forum thread. The latest one was due to still including the format for MappingPolicy and from a response formatted with an extra tick:

  utter_cheer_up:
    - image: https://i.imgur.com/nGF1K8f.jpg
    - text: Here is something to cheer you up

Here's the domain file

rasa data validate just outputs this:

(rasa) ➜  test rasa data validate --domain domain2.yml
YamlValidationException: Failed to validate '/Users/chris/Downloads/test/domain2.yml'. Please make sure the file is correct and all mandatory parameters are specified. Here are the errors found during validation

@ancalita
Copy link
Member

PR merged to 2.6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants