Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation after loading data #1399

Merged
merged 9 commits into from Sep 24, 2018
Merged

validation after loading data #1399

merged 9 commits into from Sep 24, 2018

Conversation

MetcalfeTom
Copy link
Contributor

@MetcalfeTom MetcalfeTom commented Sep 18, 2018

Fix for issue #1327

Proposed changes:

  • Data is no longer validated on initialisaition of TraningData class, since it conflicts with merging. It is validated after loading.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@MetcalfeTom MetcalfeTom requested review from akelad and removed request for Ghostvv September 21, 2018 09:30
@MetcalfeTom MetcalfeTom merged commit e071128 into master Sep 24, 2018
@akelad akelad deleted the merge-data-before-check branch September 24, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants