Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle emojis when running as server #1538

Merged
merged 5 commits into from
Nov 20, 2018
Merged

handle emojis when running as server #1538

merged 5 commits into from
Nov 20, 2018

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Nov 19, 2018 •
edited
Loading

Issue: #1489

Proposed changes:

  • replace pyaml with ruamel.yaml since it is
    • better supported
    • handles emojis in yamls out of the box
  • provide encoding for the created tmp file

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • [ ] updated the documentation
  • updated the changelog

@wochinge wochinge requested a review from tmbo November 19, 2018 18:19
tmbo
tmbo approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - finally some emoji ❤️

@wochinge wochinge merged commit 1c762f4 into master Nov 20, 2018
@wochinge wochinge deleted the emojis_server branch November 20, 2018 13:06
@wochinge wochinge mentioned this pull request Nov 20, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wochinge @tmbo