Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Docker documentation #1568

Merged
merged 3 commits into from Dec 5, 2018
Merged

Improved Docker documentation #1568

merged 3 commits into from Dec 5, 2018

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Dec 4, 2018

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • [ ] added some tests for the functionality
  • updated the documentation
  • updated the changelog

Copy link
Contributor

@JustinaPetr JustinaPetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only added one tiny suggestion :)

docs/docker.rst Outdated Show resolved Hide resolved
@wochinge wochinge merged commit 3f353c9 into master Dec 5, 2018
@wochinge wochinge deleted the more_docker_docs branch December 5, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants