Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fossa check #1634

Merged
merged 5 commits into from Jan 23, 2019
Merged

Added fossa check #1634

merged 5 commits into from Jan 23, 2019

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Jan 21, 2019

Proposed changes:

  • makes sure that we do not add any dependencies with an incompatible license
  • travis will check fossa on every build to make sure we are alerted on PR builds

Status (please check what you already did):

  • made PR ready for code review

@codeclimate
Copy link

codeclimate bot commented Jan 21, 2019

Code Climate has analyzed commit dd25791 and detected 0 issues on this pull request.

View more on Code Climate.

@tmbo tmbo requested a review from wochinge January 21, 2019 19:10
@tmbo tmbo added this to the 0.14 release milestone Jan 21, 2019
wochinge
wochinge approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.travis.yml Outdated Show resolved Hide resolved
@wochinge @tmbo
Update .travis.yml
85b8d4a 
Co-Authored-By: tmbo <tom@rasa.com>
@tmbo tmbo merged commit df6ce0c into master Jan 23, 2019
@tmbo tmbo deleted the added-fossa-check branch January 23, 2019 09:57
tmbo added a commit that referenced this pull request Mar 21, 2019
@tmbo
Merge pull request #1634 from RasaHQ/fix-domain-persistence
029c8ff 
properly instantiate domain properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmbo @wochinge