Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sklearn req #1640

Merged
merged 2 commits into from Jan 23, 2019
Merged

Fix sklearn req #1640

merged 2 commits into from Jan 23, 2019

Conversation

akelad
Copy link
Contributor

@akelad akelad commented Jan 23, 2019

Proposed changes:

  • scikit-learn should be a global requirement

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@akelad akelad requested a review from tmbo January 23, 2019 14:01
@codeclimate
Copy link

codeclimate bot commented Jan 23, 2019

Code Climate has analyzed commit b093729 and detected 0 issues on this pull request.

View more on Code Climate.

tmbo
tmbo approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - please tag a new version once merged 👍

@akelad akelad merged commit 2474efb into master Jan 23, 2019
@akelad akelad deleted the fix_sklearn_req branch January 23, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akelad @tmbo