Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated component lifecycle image #1717

Merged
merged 1 commit into from Feb 20, 2019
Merged

Conversation

JustinaPetr
Copy link
Contributor

@JustinaPetr JustinaPetr commented Feb 20, 2019

Proposed changes:

  • Updated Component Lifecycle image

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@codeclimate
Copy link

codeclimate bot commented Feb 20, 2019

Code Climate has analyzed commit 1ad79c9 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot 💯

@JustinaPetr JustinaPetr merged commit 4a28abb into master Feb 20, 2019
@JustinaPetr JustinaPetr deleted the update-component-lifecycle branch February 20, 2019 16:45
tmbo added a commit that referenced this pull request Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants