Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extractors overlap #1760

Merged
merged 6 commits into from Mar 6, 2019
Merged

Fix extractors overlap #1760

merged 6 commits into from Mar 6, 2019

Conversation

EPedrotti
Copy link
Contributor

Proposed changes:

  • update do_extractors_support_overlap to return false with empty list of extractors

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@EPedrotti EPedrotti requested a review from akelad March 5, 2019 16:46
@codeclimate
Copy link

codeclimate bot commented Mar 5, 2019

Code Climate has analyzed commit 1cc2b2c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just the one thing in the Changelog and we're good to merge

CHANGELOG.rst Outdated
@@ -43,9 +43,12 @@ Removed

Fixed
-----
- do_extractors_support_overlap now correctly throws an exception only if no extractors are passed or if extractors that do not
support overlapping entities are used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make that on one line

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@tmbo tmbo merged commit c75241d into master Mar 6, 2019
@tmbo tmbo deleted the fix-extractors-overlap branch March 6, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants