New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extractors overlap #1760
Fix extractors overlap #1760
Conversation
Code Climate has analyzed commit 1cc2b2c and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just the one thing in the Changelog and we're good to merge
CHANGELOG.rst
Outdated
@@ -43,9 +43,12 @@ Removed | |||
|
|||
Fixed | |||
----- | |||
- do_extractors_support_overlap now correctly throws an exception only if no extractors are passed or if extractors that do not | |||
support overlapping entities are used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make that on one line
Proposed changes:
Status (please check what you already did):