Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dockerfile sample configs #1764

Merged
merged 4 commits into from Mar 12, 2019
Merged

Update dockerfile sample configs #1764

merged 4 commits into from Mar 12, 2019

Conversation

ricwo
Copy link
Contributor

@ricwo ricwo commented Mar 6, 2019 •
edited

Proposed changes:

  • fix dockerfile COPY commands to reflect pipeline renaming
  • add sample config for German spacy

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@codeclimate
Copy link

codeclimate bot commented Mar 6, 2019 •
edited

Code Climate has analyzed commit 5604832 and detected 0 issues on this pull request.

View more on Code Climate.

@ricwo ricwo requested a review from amn41 March 6, 2019 14:07
amn41
amn41 approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@amn41 amn41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tmbo tmbo merged commit 8edaa61 into master Mar 12, 2019
@tmbo tmbo deleted the update-dockerfile-sample-configs branch March 12, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amn41 amn41 amn41 approved these changes

Assignees

@ricwo ricwo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ricwo @amn41 @tmbo