Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor es5 pipelines to have a dedicated module registry #6

Open
unscriptable opened this issue Mar 25, 2014 · 2 comments
Open

Refactor es5 pipelines to have a dedicated module registry #6

unscriptable opened this issue Mar 25, 2014 · 2 comments

Comments

@unscriptable
Copy link
Contributor

According to this js-loaders issue, we need to manage our own ES5 modules with a separate module registry.

@unscriptable
Copy link
Contributor Author

The ES6 loader will not support circular dependencies in anything but ES6 modules. The proposed way to handle this is with a separate registry (cache) for ES5 modules (AMD, node), bypassing the ES6 instantiate hook's dependency fetching feature.

There's a silver lining here! Keeping our own registry allows us to avoid having to transform ES5 modules to ES6 and back again when they are passed through the ES6 loader! This improves performance and removes ugly hacks!! Woohoo!

@unscriptable
Copy link
Contributor Author

Guy Bedford has an alternate proposal that would eliminate the side registry. I'm waiting to see if his proposal gains any traction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant