Hitting API Populate on Leader Board #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaviTejaM9602
changed the title
RaviTejaM9602
changed the title
BrianSammit
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
STATUS: APPROVED 馃煝 馃憦
Hello @RaviTejaM9602,
Your project is complete! There is nothing else to say other than... Great job 馃憦
Congratulations! 馃帀
TO HIGHLIGHT:
- Your project is professional
- Your repo is professional
- Well structured files
Now you can merge this branch and move on 馃
HAPPY CODING AND GOOD LUCK WITH THE COMMING ONES 馃 馃崁
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I have worked on these things 馃憤
鉁旓笍 I have created a new game by using the API.
鉁旓笍 I have created the "Refresh" button (receiving data from the API and parsing the JSON).
鉁旓笍 I have created the form "Submit" button (sending data to the API).
鉁旓笍 I have used async and await JavaScript features to consume the API.
鉁旓笍 I have correctly followed Gitflow.
鉁旓笍 I have documented my work in a professional way.
鉁旓笍 I have followed the best practices for JavaScript.
鉁旓笍 No linter errors