-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some ideas or features to implement #19
Comments
Thank you for your ideas.
Ideally I'd like to offer both and choice for user (json or database), but it's still too early to do/plan today. BorgWarehouse is still young and I have other priorities like notifications or user interface (sorting...) Have a good night ! |
You can almost do whatever you want. This Valheim docker image is not built to be used with Apprise, its integration is seamless.
|
Interesting, in the idea I can allow you in the account settings to enter your Apprise API URL and I trigger the curl on the backend in case of down so that you receive the notification. But I guess your API is secured with a password to put in the CURL header ? I can add this function if you help me to test it because I don't have an Apprise service ;) |
Hello,
Yeah, being able to select things like :
should do the trick, at least for an alpha roll.
It's not, by design, see https://github.com/caronc/apprise-api#api-notes |
Hi @shadowKing001 ! A little teasing to tell you that the Apprise feature is coming soon 🤩 It takes time because even if it doesn't look like it, it's a lot of work. And I also had to discover and learn how Apprise works in order to successfully integrate this functionality. The feature will be ready in the next few days, I will keep you informed here. I hope you will like it ☺ |
Hello, Nice addition, sorry I couldn't help you, I've been very busy these last weeks. |
Hello, I tried your apprise implementation, work flawlessly with the test notification. |
@shadowKing001 Remember to check that your sudoers file is correct, because there were some changes and it is now versioned here: https://github.com/Ravinou/borgwarehouse/blob/main/docs/sudoers/10-borgwarehouse So I also use Apprise now and send my notifications to a personal Matrix instance. It's great. It was a lot of work and a big feature over several days and hundreds of lines of code, but I'm proud of it ! |
Apprise : Allows to send notifications to many notifications services, e.g. I'm hosting my apprise container, and I use basic curl commands sent to the Apprise API to spawn notifications on my Discord server. Could be a nice addition to mail notifications.
Docker : I see that you plan to create a Docker image, it could be nice to think about Linuxserver variable type PUID and PGID. BorgWarehouse can perfecly fit on a NAS, and as you probably know, UID and GID can be a mess on these. Forget about running 1000/1000, if you want to deal with the ACL properly, the best way is to map users from the container to the host, it saves a lot of time and does its "magic"
Documentation : I didn't see anywhere in the documentation that trying to login on a http page would not proceed. When I was clicking on Login through http://xxxxx:3000, no error, but I was remaining on the same page. Once I reached BWH through my reverse proxy, I could log on. I don't know if logging through TLS only is a bug or intended, but in the second case, maybe an error or a warning on the page could be nice.
Group devices : I have multiple repositories for each device, being able to group up them through the GUI on specific tags (e.g. devices here) could provide an ease of reading.
Connect to an InfluxDB/Prometheus database
Of course, I don't think you are out of ideas to improve BorgWarehouse, nor having much free time to spend ;) just my 2 cents.
The text was updated successfully, but these errors were encountered: