Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask to confirm before creating the gist #7

Merged
merged 1 commit into from
May 14, 2023

Conversation

lnc3l0t
Copy link
Contributor

@lnc3l0t lnc3l0t commented May 14, 2023

The plugin by default creates the gist even if the user tries to cancel out because of an error in the descriptio or privacy setting.

Asking to confirm would be smarter, now by default if you spam press enter after CreateGist it doesn't create it you actually have to type y at the end.

Something we might add:

  • Option to disable this setting (useful if someone uses the plugin a lot and gets bored of typing to confirm)
  • More informative message when asking confirmation (print the description and privacy maybe)

The plugin by default doesn't create the gist if the user doens't type 'y' at the end of 'CreateGist' flow
@rawnly rawnly merged commit 13dc9cb into rawnly:main May 14, 2023
@rawnly
Copy link
Owner

rawnly commented May 14, 2023

  • Option to disable this setting

I'm open to add both, I'm quite new to plugin dev so I did the bare minimum to make this work but any help is appreciated

@lnc3l0t
Copy link
Contributor Author

lnc3l0t commented May 15, 2023

I will maybe contribute some more to it! I am very new too, but I really enjoy it

We should contribute to This Week In Neovim with the changes I made.
If you're not familiar with the website, it's a weekly newsletter about the Neovim editor. Unfortunately, the dev is currently going through a rough time maintaining it, as described in this Reddit post. By contributing, we could help support the developer and also promote your plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants