Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Lambertian updates Chapter 10 RestOfYourLife #286

Closed
trevordblack opened this issue Dec 3, 2019 · 1 comment
Closed

Image: Lambertian updates Chapter 10 RestOfYourLife #286

trevordblack opened this issue Dec 3, 2019 · 1 comment
Assignees
Milestone

Comments

@trevordblack
Copy link
Collaborator

trevordblack commented Dec 3, 2019

We’ve basically gotten this same picture (with different levels of noise) with several different
sampling patterns. It looks like the original picture was slightly wrong! Note by “wrong” here I
mean not a correct Lambertian picture. But Lambertian is just an ideal approximation to matte, so
our original picture was some other accidental approximation to matte. I don’t think the new one is
any better, but we can at least compare it more easily with other Lambertian renderers.

We don't yet know if this will be the case after the new lambertian is propagated through the codebase.

@hollasch hollasch added this to the Future milestone Dec 5, 2019
@trevordblack trevordblack self-assigned this Dec 5, 2019
@hollasch hollasch modified the milestones: Future, v3+ Jan 16, 2020
@hollasch hollasch modified the milestones: v3+, v3.0.1, v3.1.0 Mar 23, 2020
@hollasch hollasch modified the milestones: v3.1.0, v3.2.0 May 1, 2020
@hollasch hollasch changed the title Lambertian Picture Uncertainty in Chapter 10 RestOfYourLife Image: Lambertian updates Chapter 10 RestOfYourLife May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants