Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default language per-user #50

Closed
Raynes opened this issue Feb 4, 2012 · 3 comments · Fixed by #112
Closed

Set default language per-user #50

Raynes opened this issue Feb 4, 2012 · 3 comments · Fixed by #112

Comments

@Raynes
Copy link
Owner

Raynes commented Feb 4, 2012

We should add the default language as a setting for users.

@amcnamara Might want to start thinking about where we'd put a setting like this.

@amcnamara
Copy link
Collaborator

This would be best stored in a cookie, presumably. I don't see any good reason to store this server-side, other than continuity across browsers (not a huge deal).

@Raynes
Copy link
Owner Author

Raynes commented Feb 21, 2012

Sounds good to me. If we store it in a cookie, we don't necessarily have to have a setting. Would it be fair to just keep track of the language the user last selected? Or perhaps the language the user has used most? Either of these would be easy to implement. If it seems reasonable (and I think it is, given that we have the lang parameter), I'd like to avoid having a setting.

@amcnamara
Copy link
Collaborator

I'd go with last used, it's the most straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants