Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove only the relevant target directory before using --time #33

Closed
heidezomp opened this issue Jun 6, 2019 · 4 comments
Closed

Comments

@heidezomp
Copy link

The new --time feature is cool! But it would be helpful if instead of running a full cargo clean beforehand, it would only remove the relevant directory (e.g. target/debug). Now my release build and documentation are also gone, and those take a pretty long time to build from scratch on my old and slow laptop.

@RazrFalcon
Copy link
Owner

Looks like I can remove release and/or doc, but not just debug. At least I can't find such an option. So I can add support for removing only the release dir while running cargo-bloat --release and in debug it will remove everything as previously.

And I don't think that removing the target dir without cargo is a good idea.

@jonhoo
Copy link

jonhoo commented Jun 6, 2019

I think you definitely want to go through cargo clean, otherwise you'll run into weird cases with things like CARGO_TARGET_DIR.

@heidezomp
Copy link
Author

I see what you mean with the cargo clean options. I agree with both of you on going through cargo clean. I think having the desired behavior only in release mode is better than nothing, so if you can add support for that, that would be great! 😄

In the mean time I will see whether there is an issue on adding the desired behavior to cargo clean; if not, I'll add one. The currently provided options seem inconsistent to me anyway.

@heidezomp
Copy link
Author

There didn't seem to be an issue about this yet, so I opened rust-lang/cargo#7021 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants