Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer prebuilt release binaries #52

Closed
orf opened this issue Dec 27, 2019 · 9 comments
Closed

Offer prebuilt release binaries #52

orf opened this issue Dec 27, 2019 · 9 comments

Comments

@orf
Copy link

orf commented Dec 27, 2019

Thanks for this awesome tool! I'm building a github action to run cargo bloat on projects. Would you be willing to add support for distributing pre-built binaries via github releases, for environments where a cargo install would be too slow or expensive?

This can be entirely automated with Github actions themselves.

@RazrFalcon
Copy link
Owner

for environments where a cargo install would be too slow or expensive?

cargo-bloat takes few seconds to build. That's one of the core features.

Supporting prebuild binaries is too troublesome. I prefer not to.

Also, I'm not sure why do you need cargo-bloat on CI.

@orf
Copy link
Author

orf commented Dec 28, 2019

cargo-bloat takes few seconds to build. That's one of the core features.

It depends on the system, it can take upwards of a minute.

Supporting prebuild binaries is too troublesome. I prefer not to.

Honestly I've found them to be not troublesome at all, but that's that's totally fine 👍. Even without the prebuilt binaries it may be worth looking at Github actions instead of Travis for the CI? Stuff like code annotations are really powerful, and clippy has pointed out a few changes that could be done.

Also, I'm not sure why do you need cargo-bloat on CI.

I'm working on a experimental personal project to use cargo bloat to track binary sizes in projects over time, and give feedback on changes within a merge request.

I'll leave this issue and the PR open, please close them if you don't see any value in them. Also, thanks for this awesome tool.

@RazrFalcon
Copy link
Owner

I'm not familiar with GitHub actions and I don't have enough time to learn them right now, so maybe later. For now, you can host your own builds if build time is critical. If more people find it useful then I will reconsider this.

@orf
Copy link
Author

orf commented Apr 27, 2020

I just wanted to let you know that I finally got around to releasing the github-action tool based on cargo-bloat: https://github.com/orf/cargo-bloat-action

Thanks for your work on this project 🙏. I ended up installing acargo-bloat with --development to speed up installs, but even then it can take upwards of a minute. I guess that's not too bad, but I'm more than happy to help if you reconsider github-actions in the future.

@RazrFalcon
Copy link
Owner

Hi! Yes, I saw your project. Nice work. I don't use github actions, though.

As for this issue in particular, can we simply publish a prebuilt 64bit version with musl just for linux? Will it be enough?

@orf
Copy link
Author

orf commented Apr 27, 2020

Sure, that would be enough, if you're willing to do that. Honestly though, it's fine for now. Maybe with the next release?

@RazrFalcon
Copy link
Owner

I can attach a binary to the latest release on github. I don't need to update anything.

@orf
Copy link
Author

orf commented Apr 27, 2020

Ok, that would be fantastic. I can update the workflow to use that pretty easily.

@RazrFalcon
Copy link
Owner

Done.

PS: it takes just 3sec on my machine... The CI hardware must be really slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants