Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-Forge #5424] duplicated.data.table doesn't work with by=FALSE #38

Closed
arunsrinivasan opened this issue Jun 8, 2014 · 0 comments
Closed
Assignees
Milestone

Comments

@arunsrinivasan
Copy link
Member

Submitted by: Arun ; Assigned to: Arun ; R-Forge link

duplicated.data.table documentation states that when the by argument is FALSE or NULL, it'll consider all the columns. However, by=FALSE will end up in error.

Even more, by=TRUE works the way by=FALSE should.

In an effort to fix this discrepancy, I'll remove the TRUE/FALSE dependency of 'by=' altogether and stick to by=NULL. No reason to have one logical argument working and the other ending in an error. Just more confusing.

Fix on the way.

@arunsrinivasan arunsrinivasan added this to the v1.9.4 milestone Jun 19, 2014
@arunsrinivasan arunsrinivasan self-assigned this Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant