Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-devel switch to reference counting #4058

Closed
mattdowle opened this issue Nov 19, 2019 · 1 comment · Fixed by #4059
Closed

R-devel switch to reference counting #4058

mattdowle opened this issue Nov 19, 2019 · 1 comment · Fixed by #4059
Milestone

Comments

@mattdowle
Copy link
Member

@mattdowle mattdowle commented Nov 19, 2019

From Luke and Kurt,


Hi Matt,

We're hopefully just a few weeks away from switching R-devel from
NAMED to reference counting. One of data.table's tests fails under
reference counting because the .Internal(inspect()) output is
different: it shows number of references as REF(n) instead o the NAMED
field value as NAM(n). Can you please look into adjusting your tests?

For now you can build with reference counting using a configure.site
file containing

CFLAGS="-O2 -g -Wall -pedantic -DSWITCH_TO_REFCNT"

Best,
Luke


Matt:
My debian-gcc check run will soon use -DSWITCH_TO_REFCNT and hence show
the error: so please fix as quickly as possible.
Best
-k


@mattdowle mattdowle added this to the 1.12.7 milestone Nov 19, 2019
@mattdowle mattdowle mentioned this issue Nov 19, 2019
@jangorecki
Copy link
Member

@jangorecki jangorecki commented Nov 19, 2019

great news, finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants