-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backward incompatibility due to #5112 breaking reverse dependencies #5208
Comments
Matt's revdep check #5201 (comment) indicates that the following packages may be affected:
|
iml package has already been fixed, #5201 (comment) |
@tdhock Those 20 error + 4 warning are the upper bound, yes. Take that output together with the output of |
aRbs: same error on CRAN too, not due to data.table-dev So it is only |
great thanks Matt. |
bugfix for melt when measure.vars is a named list of length=1 #5112 made a backwards-incompatible change that takes value column names from
measure.vars
list names, instead ofvalue.name
argument, in order to make the behavior ofmelt()
consistent with the documentation (specifically, formeasure.vars
).data.table/R/fmelt.R
Line 217 in 96cdef6
The above line is now applied if
length(measure.vars) == 1L
too wherevalue.name
can be overridden, which breaks some reverse dependencies as they don't find the expected column name (if relying on usingvalue.name
) in the output ofmelt()
.So, it's required to contact the maintainers of the reverse dependencies and ask them to change their code (either unlist
measure.vars
or set the names of the list correctly) and run R checks with the development version ofdata.table
.The text was updated successfully, but these errors were encountered: