Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.data.table() needs to initialize/reset setNumericRounding() #6082

Closed
MichaelChirico opened this issue Apr 12, 2024 · 3 comments · Fixed by #6103
Closed

test.data.table() needs to initialize/reset setNumericRounding() #6082

MichaelChirico opened this issue Apr 12, 2024 · 3 comments · Fixed by #6103

Comments

@MichaelChirico
Copy link
Member

Fails some tests:

setNumericRounding(2)
test.data.table()
# Error: 2 error(s) out of 11157. Search inst/tests/tests.Rraw for test number(s) 1196.1, 1

After #1898 this could be a lot worse. Best to treat numeric rounding as another initial state that we want to control and then restore to user's setting on exit.

@markseeto
Copy link
Contributor

@MichaelChirico I'd like to try doing this.

@MichaelChirico
Copy link
Member Author

great, thanks for volunteering! assigned you, please reach out if you get stuck.

@markseeto
Copy link
Contributor

Thanks @MichaelChirico.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants