Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False "allow.cartesian" error for a[!b] not-join #698

Closed
fedyakov opened this issue Jun 19, 2014 · 1 comment
Closed

False "allow.cartesian" error for a[!b] not-join #698

fedyakov opened this issue Jun 19, 2014 · 1 comment
Assignees
Milestone

Comments

@fedyakov
Copy link

The following code:

a = data.table(v=c(1, 1), key="v")
b = data.table(v=c(1, 1), key="v")
a[!b]

raises error with wording "Join results in 4 rows; more than 2 = max(nrow(x),nrow(i))." Actually, not-join cannot produce more rows than nrow(x). This test can be safely removed.

@arunsrinivasan arunsrinivasan added this to the v1.9.4 milestone Jun 19, 2014
@arunsrinivasan arunsrinivasan added Low and removed Medium labels Jun 19, 2014
@arunsrinivasan arunsrinivasan removed this from the v1.9.4 milestone Jun 26, 2014
@arunsrinivasan arunsrinivasan added this to the v1.9.4 milestone Jul 27, 2014
@arunsrinivasan arunsrinivasan self-assigned this Aug 1, 2014
@rsaporta
Copy link
Contributor

It looks like the error in #800/#837 is right where "[.data.table" references this issue

if(mult=="all"){ if(!byjoin) ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants