New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make relative transition paths work #135
Comments
Thanks! Note that this is slightly different from remix-run/react-router#2172, which I expect to have somewhat different semantics that instead tie into specifics of the router. I'm not sure where the priority on this one sits, though - a naive implementation of relative transition paths opens a whole can of worms with how the router currently is entirely indifferent to trailing slashes. |
I'm surprised more people aren't asking for this. It's awfully leaky to have components aware of their absolute paths. Are there other workarounds I'm unaware of or is everyone tightly coupling their routes like an exoskeleton that can never change? |
Don't they already sort of work when using |
Thanks for the update. I did some more experimentation and I'm getting some weird behavior. When I'm on /base-route and i call history.push('subpath'), the URL updates to /base-route/subpath but nothing happens and I get an error saying 'subpath' doesn't match any routes. Then, if I refresh the page, the route loads properly.. |
I never said the router supported it. |
Ahh just weird because they punted here in remix-run/react-router#1828 (comment). Guess work's for them? |
Router discussion is on remix-run/react-router#2172. There's really a number of complexities here. |
Cool thanks for the right link! |
I saw the issue here remix-run/react-router#1828 and it was closed to continue discussion in this repo. Apologies if this is a dupe or has already been implemented, but I could not find it anywhere.
The text was updated successfully, but these errors were encountered: