Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where did useQueries Go #364

Closed
clayrisser opened this issue Sep 13, 2016 · 4 comments
Closed

Where did useQueries Go #364

clayrisser opened this issue Sep 13, 2016 · 4 comments

Comments

@clayrisser
Copy link

clayrisser commented Sep 13, 2016

For some reason, modules that my project is depending on, all of a sudden disappeared without a trace. This is very bad and should not happen, especially without documenting the change. The specific module I am looking for is useQueries.

@ryanflorence
Copy link
Member

Sounds like the version in your package.json is very bad.
On Mon, Sep 12, 2016 at 9:28 PM Jam Risser notifications@github.com wrote:

For some reason, modules that my project is depending on, all of a sudden
disappeared without a trace. This is very bad and should not happen,
especially without documenting the change.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#364, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGHaDppt-com99GvKCcJ6Y4nWe8hC-8ks5qpiaAgaJpZM4J7SAQ
.

@clayrisser
Copy link
Author

Let me be a little clearer. What happened to useQueries in version 4. Yes I
know if I use an older version things work fine. I like my stuff being
updated, and this is preventing it.

On Tue, Sep 13, 2016, 02:57 Ryan Florence notifications@github.com wrote:

Sounds like the version in your package.json is very bad.
On Mon, Sep 12, 2016 at 9:28 PM Jam Risser notifications@github.com
wrote:

For some reason, modules that my project is depending on, all of a sudden
disappeared without a trace. This is very bad and should not happen,
especially without documenting the change.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#364, or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAGHaDppt-com99GvKCcJ6Y4nWe8hC-8ks5qpiaAgaJpZM4J7SAQ

.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#364 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF8fthqPKjHpCq1Q9wfsj0NnK3kAjPwwks5qpldYgaJpZM4J7SAQ
.

  • Jam Risser

@mjackson
Copy link
Member

Hi @jamrizzi :) With the major version bump we completely removed query parsing and handling from core. The location objects emitted by history are now a strict subset of the DOM's Location interface which does not include a query property. This change was documented in the change notes leading up to version 4.

You can still get the query string pretty easily using a 3rd-party query parsing library like query-string.

import { parse } from 'query-string'

history.listen(location => {
  const query = parse(location.search)
})

@yenshih
Copy link

yenshih commented Dec 20, 2017

I have wrote a library history-query-enhancer which enhance history with a high-order function.
Hope it helps.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants