Correct behavior of basename?

[mindjuice]

I'm using createBrowserHistory directly without react-router, and I tried setting the basename property. This worked, and prefixed the URLs I pushed with the right path.

However, I was expecting that history would also remove the prefix when handing back the current location to me.

Am I using this feature incorrectly or is there some reason for the asymmetry in basename handling?

Thanks!

[mjackson]

We currently do remove the basename prefix before giving you location objects, so yes, that is the intent. However, there aren't great tests around this, so there may be a bug.

Can you please provide some sample code? Or even better, a failing test case?

[mindjuice]

Thanks for the pointer to the code. Turns out that it's because I was passing somepath instead of /somepath. Not sure if you want to consider that a bug. We could either "fix" paths that don't start with a / or perhaps issue a console warning? I can put together a PR for either option or just leave it if you prefer.

[mjackson]

Hmmm, ya we should probably automatically add a / to the front of the basename if users don't have one. I'd be happy for a PR that does this :)