Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot include URL query in basename #564

Closed
goffioul opened this issue Feb 3, 2018 · 1 comment
Closed

Cannot include URL query in basename #564

goffioul opened this issue Feb 3, 2018 · 1 comment

Comments

@goffioul
Copy link

goffioul commented Feb 3, 2018

I have a use case where my react app can be accessed using a URL that contains query parameters, e.g. http://example.com/index.html?foo. I create the history with createBrowserHistory({basename:'/index.html?foo'}). This produces warnings and I believe the path matching will not work. The root cause of the problem is that PathUtils.hasBasename does not escape special characters in prefix to create its regular expression.

@mjackson
Copy link
Member

The basename does not support query parameters. It's a segment of the pathname.

@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants