Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit stdout/stderr output to only stuff the server renders #1

Closed
hassox opened this issue Jan 2, 2016 · 4 comments
Closed

Limit stdout/stderr output to only stuff the server renders #1

hassox opened this issue Jan 2, 2016 · 4 comments

Comments

@hassox
Copy link

hassox commented Jan 2, 2016

When rendering the component, if there is any console.log or process.stdout calls in the script that react-stdio is running, this will pollute the STDOUT stream and cause invalid JSON to be put out.
@mjackson
Copy link
Member

mjackson commented Jan 2, 2016

Ya, hmmmm... good call. I'll fix this.

@hassox
Copy link
Author

hassox commented Jan 2, 2016

Thanks!

@hassox hassox changed the title The code that react-stdio must not push anything to STDIO The code that react-stdio renders must not push anything to STDIO Jan 2, 2016
@mjackson mjackson changed the title The code that react-stdio renders must not push anything to STDIO Limit stdout/stderr output to only stuff the server renders Jan 2, 2016
@mjackson
Copy link
Member

mjackson commented Jan 2, 2016

Released in v2.0.7

@hassox
Copy link
Author

hassox commented Jan 2, 2016

fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hassox @mjackson