You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many of the domains in RMS aren't formulated in a form that makes the Jacobian sparse because of coupling between the dN_i/dt and V = RT/P sum_i(N_i) and dN_i/dt and P = RT/V*sum_i(N_i). This should be fixed for ConstantTPDomain in #53, but ConstantVDomain, ParameterizedVDomain, ParameterizedTPDomain, ConstantPDomain and ParameterizedPDomain still have dense Jacobians. Integrating volume and pressure (when not constant) in these equations following the template from #53 should make the other domains sparse as well. This should be relatively simple to implement. This should mostly just involve adjustments in Domain.jl, but getT, getV, getP and getC methods in Simulation.jl may need tweaked for these domains.
The text was updated successfully, but these errors were encountered:
Many of the domains in RMS aren't formulated in a form that makes the Jacobian sparse because of coupling between the dN_i/dt and V = RT/P sum_i(N_i) and dN_i/dt and P = RT/V*sum_i(N_i). This should be fixed for ConstantTPDomain in #53, but ConstantVDomain, ParameterizedVDomain, ParameterizedTPDomain, ConstantPDomain and ParameterizedPDomain still have dense Jacobians. Integrating volume and pressure (when not constant) in these equations following the template from #53 should make the other domains sparse as well. This should be relatively simple to implement. This should mostly just involve adjustments in Domain.jl, but getT, getV, getP and getC methods in Simulation.jl may need tweaked for these domains.
The text was updated successfully, but these errors were encountered: