Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refomulate Domains to Improve Sparsity #54

Closed
mjohnson541 opened this issue Jul 29, 2020 · 0 comments
Closed

Refomulate Domains to Improve Sparsity #54

mjohnson541 opened this issue Jul 29, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Priority: High High Priority

Comments

@mjohnson541
Copy link
Collaborator

mjohnson541 commented Jul 29, 2020

Many of the domains in RMS aren't formulated in a form that makes the Jacobian sparse because of coupling between the dN_i/dt and V = RT/P sum_i(N_i) and dN_i/dt and P = RT/V*sum_i(N_i). This should be fixed for ConstantTPDomain in #53, but ConstantVDomain, ParameterizedVDomain, ParameterizedTPDomain, ConstantPDomain and ParameterizedPDomain still have dense Jacobians. Integrating volume and pressure (when not constant) in these equations following the template from #53 should make the other domains sparse as well. This should be relatively simple to implement. This should mostly just involve adjustments in Domain.jl, but getT, getV, getP and getC methods in Simulation.jl may need tweaked for these domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Priority: High High Priority
Development

No branches or pull requests

2 participants