Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rx PCL target should be changed to portable-win8+net45+wp8+wpa81 #8

Closed
jlaanstra opened this issue Apr 29, 2014 · 4 comments
Closed

Comments

@jlaanstra
Copy link

Since Rx does not use WCF, the portable target should be updated to portable-win8+net45+wp8+wpa81 (profile259).

Although Rx.NET 2.2.4 adds Universal App support the PCL does not yet include it, or at least not according to the folder in the NuGet package.

Profile259 is the new hotness as discussed in reactiveui/splat#55, reactiveui/ReactiveUI#552 and MvvmCross/MvvmCross#660

/cc @paulcbetts @dsplaisted

@anaisbetts
Copy link
Contributor

@jlaanstra Can you try building a Profile259 PCL and running it on VS2012? If the only people who can use Profile259 are people running VS2013 Update 2 RC, that's a pretty bad look

@jlaanstra
Copy link
Author

Quoting myself from reactiveui/splat#55

Visual Studio 2012 on my machine can create a PCL targeting Profile259, but that might be because I have the WP81 SDK.

You can add Profile259 to a PCL targeting Profile78. This also works in VS2012 with and without VS2013 and Update 2 installed so we should be totally fine.

@anaisbetts
Copy link
Contributor

🆒, should've looked that up. Lemme work on a PR for this.

@anaisbetts
Copy link
Contributor

This is fixed in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants