Skip to content

Commit

Permalink
docs(ALL): fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
gluck authored and kwonoj committed Feb 11, 2016
1 parent a3cc4e7 commit 519000b
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
* **every:** remove eager predicate calls ([74c2c44](https://github.com/ReactiveX/RxJS/commit/74c2c44))
* **forkJoin:** fix forkJoin to complete if sources Array is empty. ([412b13b](https://github.com/ReactiveX/RxJS/commit/412b13b))
* **groupBy:** does not emit on unsubscribed group ([6d08705](https://github.com/ReactiveX/RxJS/commit/6d08705))
* **groupBy:** fix groupBy to use lift(), supports composability ([815cfae](https://github.com/ReactiveX/RxJS/commit/815cfae)), closes [#1085](https://github.com/ReactiveX/RxJS/issues/1085) [#1085](https://github.com/ReactiveX/RxJS/issues/1085)
* **groupBy:** fix groupBy to use lift(), supports composability ([815cfae](https://github.com/ReactiveX/RxJS/commit/815cfae)), closes [#1085](https://github.com/ReactiveX/RxJS/issues/1085)
* **merge/concat:** passed scalar observables will now complete properly ([c01b92f](https://github.com/ReactiveX/RxJS/commit/c01b92f)), closes [#1150](https://github.com/ReactiveX/RxJS/issues/1150)
* **MergeMapSubscriber:** clearfy type definitions for MergeMapSubscriber's members ([4ee5f02](https://github.com/ReactiveX/RxJS/commit/4ee5f02))
* **MergeMapSubscriber:** clarify type definitions for MergeMapSubscriber's members ([4ee5f02](https://github.com/ReactiveX/RxJS/commit/4ee5f02))
* **Observable.forEach:** errors thrown in nextHandler reject returned promise ([c5ead88](https://github.com/ReactiveX/RxJS/commit/c5ead88)), closes [#1184](https://github.com/ReactiveX/RxJS/issues/1184)
* **Observer:** fix typing to allow observation via partial observables with PartialObservable<T ([7b6da90](https://github.com/ReactiveX/RxJS/commit/7b6da90))
* **Subject:** align parameter order to match with RxJS4 ([44dfa07](https://github.com/ReactiveX/RxJS/commit/44dfa07)), closes [#1285](https://github.com/ReactiveX/RxJS/issues/1285)
* **Subject:** throw ObjectUnsubscribedError when unsubecribed ([29b630b](https://github.com/ReactiveX/RxJS/commit/29b630b)), closes [#859](https://github.com/ReactiveX/RxJS/issues/859)
* **Subject:** throw ObjectUnsubscribedError when unsubscribed ([29b630b](https://github.com/ReactiveX/RxJS/commit/29b630b)), closes [#859](https://github.com/ReactiveX/RxJS/issues/859)
* **Subscriber:** adds unsubscription when errors are thrown from user-land handlers. ([dc67d21](https://github.com/ReactiveX/RxJS/commit/dc67d21))
* **Subscription:** fix leaks caused by unsubscribe functions that throw ([9e88c2e](https://github.com/ReactiveX/RxJS/commit/9e88c2e))
* **subscriptions:** unsubscribe correctly when a Subscriber throws during synchronous dispatch. ([b1698fe](https://github.com/ReactiveX/RxJS/commit/b1698fe))
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ testing techniques.

#### <a id="macro"></a>Macro

[Macro performance tests](perf/macro) are best written for scenarios where many object instance allocations (or deallocations) are occuring. Operators
[Macro performance tests](perf/macro) are best written for scenarios where many object instance allocations (or deallocations) are occurring. Operators
that create a lot of child subscriptions, or operators that emit new objects like Observables and Subjects are definitely worth creating
macro performance tests for.

Expand Down
2 changes: 1 addition & 1 deletion MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,6 @@ didn't make sense in a JavaScript context (for example: `currentThread` when the

## Unimplemented Operators/Features

If there is a feature that used to exist in RxJS 4, but no longer does in RxJS 5, please be sure to file an issue (and preferrably a PR).
If there is a feature that used to exist in RxJS 4, but no longer does in RxJS 5, please be sure to file an issue (and preferably a PR).
In your issue, please describe the use case you have for the operator so we can better understand your need and prioritize it, and/or find
and alternative way to compose the desired behavior.
2 changes: 1 addition & 1 deletion spec/Observable-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ describe('Observable.lift', function () {
});

it('should allow injecting behaviors into all subscribers in an operator ' +
'chain when overriden', function (done) {
'chain when overridden', function (done) {
// The custom Subscriber
var log = [];
function LogSubscriber() {
Expand Down
2 changes: 1 addition & 1 deletion src/operator/distinct.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {subscribeToResult} from '../util/subscribeToResult';
* If a comparator function is provided, then it will be called for each item to test for whether or not that value should be emitted.
* If a comparator function is not provided, an equality check is used by default.
* As the internal HashSet of this operator grows larger and larger, care should be taken in the domain of inputs this operator may see.
* An optional paramter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds.
* An optional parameter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds.
* @param {function} [compare] optional comparison function called to test if an item is distinct from previous items in the source.
* @param {Observable} [flushes] optional Observable for flushing the internal HashSet of the operator.
* @returns {Observable} an Observable that emits items from the source Observable with distinct values.
Expand Down
2 changes: 1 addition & 1 deletion src/operator/distinctKey.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {Observable} from '../Observable';
* If a comparator function is provided, then it will be called for each item to test for whether or not that value should be emitted.
* If a comparator function is not provided, an equality check is used by default.
* As the internal HashSet of this operator grows larger and larger, care should be taken in the domain of inputs this operator may see.
* An optional paramter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds.
* An optional parameter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds.
* @param {string} key string key for object property lookup on each item.
* @param {function} [compare] optional comparison function called to test if an item is distinct from previous items in the source.
* @param {Observable} [flushes] optional Observable for flushing the internal HashSet of the operator.
Expand Down
2 changes: 1 addition & 1 deletion src/operator/find.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {Subscriber} from '../Subscriber';

/**
* Returns an Observable that searches for the first item in the source Observable that
* matches the specified condition, and returns the first occurence in the source.
* matches the specified condition, and returns the first occurrence in the source.
* @param {function} predicate function called with each item to test for condition matching.
* @returns {Observable} an Observable of the first item that matches the condition.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/operator/mapTo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {Observable} from '../Observable';
* <img src="./img/mapTo.png" width="100%">
*
* @param {any} value the value to map each incoming value to
* @returns {Observable} an observable of the passed value that emits everytime the source does
* @returns {Observable} an observable of the passed value that emits every time the source does
*/
export function mapTo<T, R>(value: R): Observable<R> {
return this.lift(new MapToOperator(value));
Expand Down
2 changes: 1 addition & 1 deletion src/symbol/rxSubscriber.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {SymbolShim} from '../util/SymbolShim';

/**
* rxSubscriber symbol is a symbol for retreiving an "Rx safe" Observer from an object
* rxSubscriber symbol is a symbol for retrieving an "Rx safe" Observer from an object
* "Rx safety" can be defined as an object that has all of the traits of an Rx Subscriber,
* including the ability to add and remove subscriptions to the subscription chain and
* guarantees involving event triggering (can't "next" after unsubscription, etc).
Expand Down

0 comments on commit 519000b

Please sign in to comment.