Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multicast): fix a bug that caused multicast to omit messages after termination #2021

Merged

Conversation

trxcllnt
Copy link
Member

ConnectableObservable as the multicast selector function source argument would omit events after source termination when used with historic Subjects.

Simple repro example:

Observable.of(1, 2).multicast(
  ( ) => new ReplaySubject(1),
  (x) => x.concat(x.takeLast(1)))
  .toArray()
  .subscribe((arr) => {
    if (arr.toString() !== `1,2,2`) {
      throw 'multicast missed the `takeLast(1)` event';
    }
  });

…r termination

ConnectableObservable as the multicast selector function source argument would omit events after

source termination when used with historic Subjects.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 96.978% when pulling c0815c7 on trxcllnt:multicast-with-selector-unsubscribe-fix into 1bee98a on ReactiveX:master.

@staltz
Copy link
Member

staltz commented Oct 11, 2016

LGTM

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage decreased (-0.06%) to 96.978% when pulling c0815c7 on trxcllnt:multicast-with-selector-unsubscribe-fix into 1bee98a on ReactiveX:master.

@jayphelps jayphelps merged commit 44fbc14 into ReactiveX:master Oct 24, 2016
@trxcllnt trxcllnt deleted the multicast-with-selector-unsubscribe-fix branch December 23, 2016 01:28
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants