refactor(throttle): remove tryCatch/errorObject

[tetsuharuohzeki]

• This change is same kind of Perf or no perf, there is no try... #1251.
• I have not benchmarked this yet. So this is purely refactoring to unify code style.
  • The current codebase does not have any benchmark about throttle().
  • throttle() suppress the value traffic. How do we benchmark this without a throughput benchmark?

[benlesh]

Can you flatten the first two commits? There's no reason for them to be separate, really. They're just TypeScript fixes.

[tetsuharuohzeki]

I added the micro perf benchmars for throttle() ( tetsuharuohzeki@8963abb ), but RxJS v4 does not accept Observable<T> as a durationSelector (see also #1321). So we should only watch the v5's result.
(Should we really add this benchmark to the tree?)

These are results of benchmarks (this table drops v4's results):

Before this pull request

                                         |             RxJS 5.0.0-beta.1 |
----------------------------------------------------------------------------
                    throttle - immediate |                38,030 (±2.18%) |
                                throttle |                32,392 (±5.58%) |

My first patch

                                         |             RxJS 5.0.0-beta.1 |  
----------------------------------------------------------------------------
                    throttle - immediate |                45,254 (±1.21%) |
                                throttle |                33,630 (±3.33%) |

@Blesh's proposal

                                         |             RxJS 5.0.0-beta.1 |  
----------------------------------------------------------------------------
                    throttle - immediate |                58,980 (±5.69%) |
                                throttle |                41,971 (±5.14%) |

By these results, @Blesh's suggestion is right!

[tetsuharuohzeki]

@kwonoj

updated :)
And, I add some comments which explain why we cannot compare with v4's throttle(durationSelector) to tetsuharuohzeki@6060977.

[kwonoj]

Merged with 7bae860, thanks @saneyuki !

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.