fix(Subject): throw ObjectUnsubscribedError when unsubecribed … #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -221,9 +215,6 @@ describe('Subject', function () { | |||
| subscription1.unsubscribe(); | |||
|
|
|||
| subject.complete(); | |||
| subject.next(9); | |||
| subject.complete(); | |||
| subject.error(new Error('err')); | |||
There was a problem hiding this comment.
Are we adding tests for expectations of throwing in these deleted scenarios?
There was a problem hiding this comment.
Oh, thanks for catching it. Subject's spec's are not updated to include those. Updating it now.
kwonoj
force-pushed
the
subject-unsuberror
branch
from
8166ac5
to
3feb934
Compare
|
PR's updated to add test coverage for changed behavior. |
kwonoj
force-pushed
the
subject-unsuberror
branch
from
3feb934
to
5134b54
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to close #859, now
SubjectthrowsObjectUnsubscribedErrorif it's unsubscribed. Updated operator behavior and test cases also to not emit after subject completion(error, complete, unsub)