Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MIGRATION): remove the non-exist usecase for throttle() #1321

Closed
wants to merge 1 commit into from
Closed

docs(MIGRATION): remove the non-exist usecase for throttle() #1321

wants to merge 1 commit into from

Conversation

tetsuharuohzeki
Copy link
Contributor

@kwonoj
Copy link
Member

kwonoj commented Feb 9, 2016

Doesn't RxJS5 column need to maintain throttle(durationSelector) variant?

@tetsuharuohzeki
Copy link
Contributor Author

@kwonoj

I thought this as a migration doc to move from RxJS v4. So I removed throttle(durationSelector) which is just a new feature. If the comparison doc introduces a new feature, I feel we should keep it.

@kwonoj
Copy link
Member

kwonoj commented Feb 9, 2016

Those table's for operator splits, introduces new operator variant from RxJS4's polymorphic behavior as well such as window, windowWhen, windowToggle comes from RxJS4. in case of throttle(selector) is somewhat different though since original throttle didn't have those behavior though, thought it belongs to operator split allows easier lookup. Maybe I'm incorrect still.

@kwonoj
Copy link
Member

kwonoj commented Feb 11, 2016

Merged with a3cc4e7, think it's ok as-is by not displaying RxJS 5 variant is trivial compare to showing non exist one. Thanks @saneyuki .

@kwonoj kwonoj closed this Feb 11, 2016
@tetsuharuohzeki
Copy link
Contributor Author

@kwonoj Thank you for accepting my proposal!

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants