style(every): fix typos #1331
Closed
style(every): fix typos #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1292,7 +1292,7 @@ declare module "crypto" { | |||
| update(data: any): void; | |||
| sign(private_key: string, output_format: string): string; | |||
| } | |||
| export function createVerify(algorith: string): Verify; | |||
| export function createVerify(algorithm: string): Verify; | |||
There was a problem hiding this comment.
this typing definition is not originated in this repo but comes from definitelytyped (https://github.com/DefinitelyTyped/tsd), may need to update type definition instead of modify it.
Actually I noticed this definition is not being referenced in repo, maybe we can get rid of this.
There was a problem hiding this comment.
Ok, I'll just remove this one from the change then, and let you decide whether the def should be removed.
Thx !
|
Done, rebased & amended |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and a repeated GH issue # in changelog)