feat(if): add static Observable.if creation operator. #1348
Conversation
| @@ -39,8 +39,10 @@ import './add/observable/fromArray'; | |||
| import './add/observable/fromEvent'; | |||
| import './add/observable/fromEventPattern'; | |||
| import './add/observable/fromPromise'; | |||
| import './add/observable/if'; | |||
There was a problem hiding this comment.
is this for kitchensink only? not in rx?
There was a problem hiding this comment.
@kwonoj in Rx4 Observable.if is in the "experimental" package, so I only put it into KitchenSink. I still question why we distinguish between "core" and "kitchen sink" operators in the first place.
| return elseSource.subscribe(subscriber); | ||
| } else { | ||
| subscriber.complete(); | ||
| } |
There was a problem hiding this comment.
What about moving this if to a separate function? I know this is not a very performance sensitive operator, but we can have improvements anyway.
There was a problem hiding this comment.
Sure, that's alright with me.
There was a problem hiding this comment.
@trxcllnt , would you be update PR as suggested, or proceed to check in as-is?
|
Blocking this while #1364 is merged. |
|
@trxcllnt I think this needs rebased/refactored to move the tests to TypeScript. |
trxcllnt
force-pushed
the
static-if-operator
branch
2 times, most recently
from
5efb402
to
297722c
Compare
|
@Blesh done |
trxcllnt
force-pushed
the
static-if-operator
branch
from
297722c
to
dd23ee9
Compare
trxcllnt
force-pushed
the
static-if-operator
branch
from
dd23ee9
to
f7ff7ec
Compare
|
@Blesh rebased again good 2 go |
|
I'll check this in today. :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Addresses #1343