Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(esdoc): improve esdoc page styles and structure #1374

Closed
wants to merge 1 commit into from

Conversation

staltz
Copy link
Member

@staltz staltz commented Feb 22, 2016

Introduce ReactiveX brand, with its colors, fonts, etc. Change ESDoc page structure to have a
homepage pointing to: (1) installation page, (2) manual with tutorial on the Rx concepts, (3) full
reference. These are for now placeholder for the content, to arrive in separate PRs.

To see this page live, open http://rxjs5-esdoc-facelift.surge.sh/

screen shot 2016-02-22 at 10 52 38

@kwonoj
Copy link
Member

kwonoj commented Feb 23, 2016

👍

Introduce ReactiveX brand, with its colors, fonts, etc. Change ESDoc page structure to have a
homepage pointing to: (1) installation page, (2) manual with tutorial on the Rx concepts, (3) full
reference. These are for now placeholder for the content, to arrive in separate PRs.
@kwonoj
Copy link
Member

kwonoj commented Feb 24, 2016

I'm in favor of this change but think might need input from @Blesh as well. Just label it as looks good to me on my end for now.

@benlesh
Copy link
Member

benlesh commented Feb 27, 2016

LGTM

@kwonoj
Copy link
Member

kwonoj commented Feb 27, 2016

Merged with 9715135, thanks @staltz (and @Blesh to confirm :) ). Let's move forward to other document PR opened.

@kwonoj kwonoj closed this Feb 27, 2016
@staltz staltz deleted the esdoc-facelift branch February 27, 2016 08:44
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants